frogmc/FrogLoader
6
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: Minecraft 1.20 crashing the semver parser #12

Merged
Ecorous merged 6 commits from fix/semver-crash-mc1.20 into main 2024-07-07 07:50:52 -04:00
Conversation 0 Commits 6 Files changed 3 +8 -5
ender commented 2024-07-05 19:28:52 -04:00
Owner
Copy link

Minecraft doesn't use semver, and as such, sometimes it can cause problems, like in this case: 1.20 is not a valid semver version, but we must deal with it anyway, we've made the <patch> component optional, defaulting it to 0 if missing

Minecraft doesn't use semver, and as such, sometimes it can cause problems, like in this case: `1.20` is not a valid semver version, but we must deal with it anyway, we've made the `<patch>` component optional, defaulting it to `0` if missing
ender added 1 commit 2024-07-05 19:28:52 -04:00 
Minecraft doesn't use semver, and as such, sometimes it can cause problems, like in this case: `1.20` is not a valid semver version, but we must deal with it anyway, we've made the `<patch>` component optional, defaulting it to `0` if missing
ender force-pushed fix/semver-crash-mc1.20 from 6eeade90b0 to de85222cbf 2024-07-05 19:29:13 -04:00 Compare
ender requested review from Ecorous 2024-07-05 19:30:46 -04:00
ender requested review from owlsys 2024-07-05 19:30:47 -04:00
owlsys reviewed 2024-07-05 19:30:54 -04:00
src/main/java/dev/frogmc/frogloader/impl/mod/SemVerImpl.java Outdated
@ -30,1 +32,3 @@
int patch = Integer.parseInt(matcher.group("patch"));
// minecraft treats the `patch` component as optional...
@Nullable String patchString = matcher.group("patch");
int patch = patchString == null ? 0 : Integer.parseInt(matcher.group("patch"));
owlsys commented 2024-07-05 19:30:54 -04:00
Owner
Copy link

nitpick: could use the previously assigned variable in the Integer.parseInt call

nitpick: could use the previously assigned variable in the `Integer.parseInt` call
ender commented 2024-07-05 19:31:35 -04:00
Author
Owner
Copy link

wdym?

wdym?
owlsys commented 2024-07-05 19:32:18 -04:00
Owner
Copy link
int patch = patchString == null ? 0 : Integer.parseInt(matcher.group(patchString));
```java int patch = patchString == null ? 0 : Integer.parseInt(matcher.group(patchString)); ```
ender commented 2024-07-05 19:34:21 -04:00
Author
Owner
Copy link

i'm not understanding sorry, what should i change it to?

i'm not understanding sorry, what should i change it to?
ender commented 2024-07-05 19:36:06 -04:00
Author
Owner
Copy link

OH, got it, forgot to actually us the var i added lol

OH, got it, forgot to actually us the var i added lol
owlsys marked this conversation as resolved
ender added 3 commits 2024-07-05 19:32:38 -04:00 
Minecraft doesn't use semver, and as such, sometimes it can cause problems, like in this case: `1.20` is not a valid semver version, but we must deal with it anyway, we've made the `<patch>` component optional, defaulting it to `0` if missing
It Was added by me for testing and forgot to remove it :/
ender added 1 commit 2024-07-05 19:36:51 -04:00
owlsys approved these changes 2024-07-05 21:09:09 -04:00
Ecorous approved these changes 2024-07-07 07:47:15 -04:00
Ecorous added 1 commit 2024-07-07 07:49:14 -04:00
Ecorous merged commit a0c7d27fec into main 2024-07-07 07:50:52 -04:00
Ecorous deleted branch fix/semver-crash-mc1.20 2024-07-07 07:50:57 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
owlsys
Ecorous
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: frogmc/FrogLoader#12
No description provided.
Delete branch "fix/semver-crash-mc1.20"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?