frogmc/FrogLoader
6
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: Minecraft 1.20 crashing the semver parser #12

Merged
Ecorous merged 6 commits from fix/semver-crash-mc1.20 into main 2024-07-07 07:50:52 -04:00
Conversation 0 Commits 6 Files changed 3 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 28652b7e00 - Show all commits

2
src/main/java/dev/frogmc/frogloader/impl/mod/SemVerImpl.java
View file

@ -30,7 +30,7 @@ public record SemVerImpl(int major, int minor, int patch, String prerelease, Str
int minor = Integer.parseInt(matcher.group("minor")); int minor = Integer.parseInt(matcher.group("minor"));
// minecraft treats the `patch` component as optional... // minecraft treats the `patch` component as optional...
@Nullable String patchString = matcher.group("patch"); @Nullable String patchString = matcher.group("patch");
int patch = patchString == null ? 0 : Integer.parseInt(matcher.group("patch")); int patch = patchString == null ? 0 : Integer.parseInt(patchString);
String prerelease = matcher.group("prerelease"); String prerelease = matcher.group("prerelease");
owlsys marked this conversation as resolved Outdated
owlsys commented 2024-07-05 19:30:54 -04:00
Outdated
Review
Copy link

nitpick: could use the previously assigned variable in the Integer.parseInt call

nitpick: could use the previously assigned variable in the `Integer.parseInt` call
ender commented 2024-07-05 19:31:35 -04:00
Outdated
Review
Copy link

wdym?

wdym?
owlsys commented 2024-07-05 19:32:18 -04:00
Outdated
Review
Copy link
int patch = patchString == null ? 0 : Integer.parseInt(matcher.group(patchString));
```java int patch = patchString == null ? 0 : Integer.parseInt(matcher.group(patchString)); ```
ender commented 2024-07-05 19:34:21 -04:00
Outdated
Review
Copy link

i'm not understanding sorry, what should i change it to?

i'm not understanding sorry, what should i change it to?
ender commented 2024-07-05 19:36:06 -04:00
Outdated
Review
Copy link

OH, got it, forgot to actually us the var i added lol

OH, got it, forgot to actually us the var i added lol
String buildmetadata = matcher.group("buildmetadata"); String buildmetadata = matcher.group("buildmetadata");
return new SemVerImpl(major, minor, patch, prerelease, buildmetadata); return new SemVerImpl(major, minor, patch, prerelease, buildmetadata);