frogmc/FrogLoader
6
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Convert ModDependencies to an interface #15

Merged
owlsys merged 3 commits from TheKodeToad/mod-dependencies-iface into main 2024-09-02 12:09:57 -04:00
Conversation 0 Commits 3 Files changed 7 +118 -108
kode commented 2024-09-01 10:20:24 -04:00
Owner
Copy link

Blocked by #14

Blocked by #14
kode added 2 commits 2024-09-01 10:20:24 -04:00
kode changed title from TheKodeToad/mod-dependencies-iface to Convert ModDependencies to an interface 2024-09-01 10:20:34 -04:00
owlsys reviewed 2024-09-02 10:35:16 -04:00
src/main/java/dev/frogmc/frogloader/api/mod/ModDependencies.java Outdated
@ -97,3 +45,1 @@
private final String range;
private final String link;
private final String name;
interface Entry {
owlsys commented 2024-09-02 10:34:10 -04:00
Owner
Copy link

This class is missing javadocs

This class is missing javadocs
kode commented 2024-09-02 12:04:13 -04:00
Author
Owner
Copy link

Added them, also hopefully added @Nullable on everything which can be null LMK if it's correct

Added them, also hopefully added @Nullable on everything which can be null LMK if it's correct
kode marked this conversation as resolved
src/main/java/dev/frogmc/frogloader/impl/mod/ModDependenciesImpl.java
@ -0,0 +37,4 @@
* @param suggests <code>Type.SUGGEST</code> entries
* @param provides <code>Type.PROVIDE</code> entries
*/
@ApiStatus.Internal
owlsys commented 2024-09-02 10:33:18 -04:00
Owner
Copy link

the @ApiStatus.Internal annotation can be removed

the `@ApiStatus.Internal` annotation can be removed
kode marked this conversation as resolved
kode added 1 commit 2024-09-02 12:03:33 -04:00
owlsys approved these changes 2024-09-02 12:06:38 -04:00
kode added 1 commit 2024-09-02 12:09:15 -04:00
owlsys merged commit b3085264ee into main 2024-09-02 12:09:57 -04:00
owlsys deleted branch TheKodeToad/mod-dependencies-iface 2024-09-02 12:09:57 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
owlsys
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: frogmc/FrogLoader#15
No description provided.
Delete branch "TheKodeToad/mod-dependencies-iface"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?