Simplify Env #16

Merged
owlsys merged 3 commits from TheKodeToad/simplify-env into main 2024-09-02 12:33:40 -04:00
Owner

I don't think getMixinName needs to be publicly exposed

I don't think getMixinName needs to be publicly exposed
kode added 1 commit 2024-09-02 12:17:53 -04:00
owlsys reviewed 2024-09-02 12:24:26 -04:00
@ -19,6 +20,7 @@ import org.spongepowered.asm.mixin.transformer.IMixinTransformer;
import org.spongepowered.asm.mixin.transformer.IMixinTransformerFactory;
import org.spongepowered.asm.service.*;
import org.spongepowered.asm.transformers.MixinClassReader;
import org.spongepowered.asm.util.Constants;
Owner

this import doesn't seem to be used anywhere (in this diff)

this import doesn't seem to be used anywhere (in this diff)
kode marked this conversation as resolved
@ -121,3 +123,3 @@
@Override
public String getSideName() {
return FrogLauncher.getInstance().getEnv().getMixinName();
return FrogLauncher.getInstance().getEnv().name();
Owner

did you test that this still works?

did you test that this still works?
Author
Owner

It launches

It launches
kode marked this conversation as resolved
kode added 1 commit 2024-09-02 12:25:55 -04:00
owlsys added 1 commit 2024-09-02 12:33:20 -04:00
owlsys merged commit d3e0ead81e into main 2024-09-02 12:33:40 -04:00
owlsys deleted branch TheKodeToad/simplify-env 2024-09-02 12:33:44 -04:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: frogmc/FrogLoader#16
No description provided.