frogmc/phytotelma
6
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

using parchment: parameter names & javadoc; use vineflower for source generation #1

Merged
owlsys merged 4 commits from parchment into mistress 2024-05-18 07:05:46 -04:00
Conversation 0 Commits 4 Files changed 5 +78 -34
owlsys commented 2024-05-17 14:53:34 -04:00
Owner
Copy link
  • save pom file for gradle to be able to find the generated sourcesJar on its own
- save pom file for gradle to be able to find the generated sourcesJar on its own
owlsys added 3 commits 2024-05-17 14:53:34 -04:00
start implementing javadoc and parameter name injection using parchmentmc
All checks were successful
Publish to snapshot maven / build (push) Successful in 21s
Details
83aa861eb9
finish implementing parameters and javadocs
All checks were successful
Publish to snapshot maven / build (push) Successful in 21s
Details
9006dbf994
revert build script changes
All checks were successful
Publish to snapshot maven / build (push) Successful in 20s
Details
b8fc7bb9db
kode reviewed 2024-05-17 14:58:36 -04:00
src/main/kotlin/org/ecorous/esnesnon/gradle/vineflower/ParchmentJavadocProvider.kt Outdated
@ -10,1 +9,3 @@
return ""
class ParchmentJavadocProvider(private val parchment: Parchment) : IFabricJavadocProvider {
override fun getClassDoc(structClass: StructClass): String? {
return parchment.getClass(structClass.qualifiedName).map { it.javadoc }.map { it.joinToString { "\n" } }
kode commented 2024-05-17 14:58:36 -04:00
Owner
Copy link

might be nicer in kotlin to do .orElse(null) and use ?.
or at least combine the map calls into one as it seems unnecessary to split them

might be nicer in kotlin to do .orElse(null) and use ?. or at least combine the map calls into one as it seems unnecessary to split them
Ecorous approved these changes 2024-05-17 14:58:49 -04:00
Ecorous left a comment
Owner
Copy link

Looks good

Looks good
owlsys added 1 commit 2024-05-17 15:03:22 -04:00
reduce map operations
All checks were successful
Publish to snapshot maven / build (push) Successful in 20s
Details
579e99e26f
owlsys merged commit 52af4fefb8 into mistress 2024-05-18 07:05:46 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Ecorous
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: frogmc/phytotelma#1
No description provided.
Delete branch "parchment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?